Make shellcheck happy + minor cleanups

db_scripts/init_rmps_db.sh

@@ -1,18 +1,18 @@
 #!/bin/bash
 
 printf "Password for 'rmps' DB user: "
-read -s dbpass
+read -rs dbpass
 printf "\nEnter the first RMPS username: "
-read username
-printf "Full name for the new user '$username': "
-read fullname
-printf "Password for RMPS user '$username': "
-read -s newuser_pass
+read -r username
+printf "Full name for the new user '%s': " "${username}"
+read -r fullname
+printf "Password for RMPS user '%s': " "${username}"
+read -rs newuser_pass
 printf "\nEnter e-mail for the new user: "
-read email
+read -r email
 printf "Initializing DB... "
-salt=`head -c 32 /dev/urandom|sha1sum|head -c 32`
-pass_hash=`printf ${newuser_pass}${salt}|sha512sum|head -c 128`
+salt=$(head -c 32 /dev/urandom|sha1sum|head -c 32)
+pass_hash=$(printf "%s%s" "${newuser_pass}" "${salt}"|sha512sum|head -c 128)
 
 #printf "\nSalt = $salt"
 #printf "\nHash = $pass_hash\n"
@@ -23,5 +23,5 @@ mysql -u rmps --password="$dbpass" -e "\
 	set @eMail=\"$email\";\
 	set @passHash=\"$pass_hash\";\
 	set @passSalt=\"$salt\";\
-	`cat init_rmps_db.sql`"
-printf 'Done!\n'
+	$(cat init_rmps_db.sql)"
+printf "Done!\n"

db_scripts/init_rmps_db.sql

@@ -180,4 +180,3 @@ END $$
 
 DELIMITER ;
 
-